feat(asset): Added calibration forecast query builder #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saradei-ni
force-pushed
the
users/saradei-ni/2798210
branch
2 times, most recently
from
6662012
to
a5a6453
Compare
|
Please add a description and a prepare a gif to highlight the functionality in the description |
kkerezsi
approved these changes
Sep 26, 2024
src/datasources/asset-calibration/components/AssetCalibrationQueryBuilder.tsx
Outdated
Show resolved
Hide resolved
src/datasources/asset-calibration/components/AssetCalibrationQueryBuilder.tsx
Outdated
Show resolved
Hide resolved
kkerezsi
reviewed
Sep 26, 2024
src/datasources/asset-calibration/components/AssetCalibrationQueryBuilder.tsx
Outdated
Show resolved
Hide resolved
src/datasources/asset-calibration/components/AssetCalibrationQueryBuilder.tsx
Outdated
Show resolved
Hide resolved
src/datasources/asset-calibration/components/AssetCalibrationQueryEditor.tsx
Outdated
Show resolved
Hide resolved
saradei-ni
force-pushed
the
users/saradei-ni/2798210
branch
from
a5a6453
to
41d7f38
Compare
saradei-ni
requested review from
CiprianAnton,
mure and
cameronwaterman
as code owners
kkerezsi
approved these changes
Sep 30, 2024
|
@mure Is there any possibility to get this reviewed? The PR is out for some time now and we are expecting to start testing it |
mure
reviewed
Sep 30, 2024
src/datasources/asset-calibration/AssetCalibrationDataSource.ts
Outdated
Show resolved
Hide resolved
src/datasources/asset-calibration/components/AssetCalibrationQueryEditor.tsx
Outdated
Show resolved
Hide resolved
saradei-ni
force-pushed
the
users/saradei-ni/2798210
branch
from
41d7f38
to
3bdfb14
Compare
saradei-ni
force-pushed
the
users/saradei-ni/2798210
branch
from
3bdfb14
to
ce7ad2b
Compare
|
@mure can you please take a look again? The feedback has been addressed. |
mure
approved these changes
Oct 2, 2024
mure
pushed a commit
that referenced
this pull request
Oct 2, 2024
## [3.15.0](v3.14.1...v3.15.0) (2024-10-02) ### Features * **asset:** Added calibration forecast query builder ([#69](#69)) ([99f2fff](99f2fff))
|
🎉 This PR is included in version 3.15.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
User Story 2798210: [UI][Grafana] Add support for filters on the Grafana plugin
👩💻 Implementation
🧪 Testing
Added unit tests.
GIF of the query builder sending the right requests.
✅ Checklist